Removes CL from ID Computer & updates "centcom" #3725
Conversation
Co-authored-by: fira <[email protected]>
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
There was a problem hiding this comment.
This all appears working except that the access tab (the first one) is not altered when in wey_yu mode. Namely the grant all button behaves significantly differently in wey_yu mode but the individual regions displayed are still the marine ones.
I don't know exactly what regions should be displayed other than the default, but the grant all access behavior is different than the individual regions when grant all should just be a select all of the individual options button.
In marine mode, grant all grants 34 items, but selecting every entry individually is only 31 items (you can get this up to 35 items if you grant all and then also grant region on Almayer Command because the Commander's quarters doesn't work if you click it - only via region - and it isn't part of grant all).
In wey yu mode, grant all grants 6 items, none of which are the 31-32 you can individually select.
If you try to max access via both modes you can get up to 41 entries.
By default when spawned via create_humans, a CL has this 13 items in their access list:
So all of this is to say that the grant all behavior does not line up with the listed regions. In marine mode it is close.
Feel free to undraft and we can move forward with this PR if you would rather address this separately.
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
About the pull request
People were using the CL's preset in ID computer to gain access to CLs office when this shouldn't really be possible. This stops that, and also makes it so switching the computer to WY mode actually does something.
Explain why it's good for the game
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>tags.Changelog
🆑
add: Added proper assignments for wey-yu mode on ID computers.
del: Removed CL from ID Computer unless on WY mode.
/:cl: